Handle log context with more than 100 metrics #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredcnance
approved these changes
Sep 19, 2020
| public String serialize() throws JsonProcessingException { | ||
| return this.rootNode.serialize(); | ||
| public List<String> serialize() throws JsonProcessingException { | ||
| if (rootNode.metrics().size() <= Constants.MAX_METRICS_PER_EVENT) { |
There was a problem hiding this comment.
I recommend adding a comment about what you’re doing here and why. Unfortunately, this bit of complexity exists because of constraints in the backend and it may not be clear to others what’s happening here.
| aws.getCloudWatchMetrics().stream() | ||
| .flatMap(metricDirective -> metricDirective.getMetrics().values().stream()) | ||
| .collect(Collectors.toList()); | ||
| for (MetricDefinition metric : metrics) { |
There was a problem hiding this comment.
We’re iterating over this collection twice. Can we do this in one pass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#41
Description of changes:
Handle the case that there're more than 100 metrics in a metric context. The metrics would be split into multiple log event message in this case. There would be 100 metrics in the first several log message and the last one may have less than 100 log messages.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.